zhangyue19921010 commented on a change in pull request #4172:
URL: https://github.com/apache/hudi/pull/4172#discussion_r765635846
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java
##########
@@ -136,6 +136,14 @@ public HoodieTimeline filterPendingCompactionTimeline() {
instants.stream().filter(s ->
s.getAction().equals(HoodieTimeline.COMPACTION_ACTION) && !s.isCompleted()),
details);
}
+ @Override
+ public HoodieTimeline filterPendingCompactionAndReplaceTimeline() {
Review comment:
Nice idea.
For now there are three kinds of table services including `CLUSTER`,
`COMPACT` and `CLEAN` . And only commit service could stain the active timeline.
With the continuous development of HUDI, there may be more and more types of
commits service. It's better to put some restrictions in case that stain the
active timeline by accident.
I may spend time on this. Maybe contribute a another PR to make it happen :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
