leesf commented on a change in pull request #4291:
URL: https://github.com/apache/hudi/pull/4291#discussion_r767436889
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -331,19 +338,32 @@ private boolean syncSchema(String tableName, boolean
tableExists, boolean useRea
* Syncs the list of storage partitions passed in (checks if the partition
is in hive, if not adds it or if the
* partition path does not match, it updates the partition path).
*/
- private boolean syncPartitions(String tableName, List<String>
writtenPartitionsSince) {
+ private boolean syncPartitions(String tableName, List<String>
writtenPartitionsSince, boolean isDeletePartition) {
Review comment:
rename to `isDropPartition` to align with PartitionEvenType.DROP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
