zhangyue19921010 commented on a change in pull request #4078:
URL: https://github.com/apache/hudi/pull/4078#discussion_r769306591
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiveLog.java
##########
@@ -183,6 +217,24 @@ public void testArchiveTableWithArchival(boolean
enableMetadata) throws Exceptio
}
}
+ @ParameterizedTest
+ @MethodSource("testArchiveTableWithArchivalCleanUp")
+ public void testArchiveTableWithArchivalCleanUp(boolean enableMetadata,
boolean enableArchiveClean, int archiveFilesToKeep) throws Exception {
+ HoodieWriteConfig writeConfig =
initTestTableAndGetWriteConfig(enableMetadata, 2, 3, 2, enableArchiveClean,
archiveFilesToKeep);
+ for (int i = 1; i < 10; i++) {
+ testTable.doWriteOperation("0000000" + i, WriteOperationType.UPSERT, i
== 1 ? Arrays.asList("p1", "p2") : Collections.emptyList(), Arrays.asList("p1",
"p2"), 2);
+ // trigger archival
+ archiveAndGetCommitsList(writeConfig);
+ }
+ String archivePath = metaClient.getArchivePath();
+ RemoteIterator<LocatedFileStatus> iter = metaClient.getFs().listFiles(new
Path(archivePath), false);
+ ArrayList<LocatedFileStatus> files = new ArrayList<>();
+ while (iter.hasNext()) {
+ files.add(iter.next());
+ }
+ assertEquals(archiveFilesToKeep, files.size());
Review comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
