[GitHub] [hudi] YannByron commented on pull request #4083: [HUDI-2837] The original hoodie.table.name should be maintained in Spark SQL

Tue, 28 Dec 2021 19:30:31 -0800 


YannByron commented on pull request #4083:
URL: https://github.com/apache/hudi/pull/4083#issuecomment-1002380413


   @dongkelun @xushiyan 
   I offer another solution to discuss.
   
   Query incrementally in hive need to set `hoodie.%s.consume.start.timestamp` 
which is used in `HoodieHiveUtils.readStartCommitTime`。Currently, we pass the 
`hoodie.table.name` named `tableName` to this function.
   We can add configs `hoodie.datasource.write.database.name` in 
`DataSourceWriteOptions` and `hoodie.database.name` in `HoodieTableConfig`. And 
if `database.name` provided, we joint the `database.name` and `table.name` and 
pass it to `readStartCommitTime`. And then, use can set 
`hoodie.dbName.tableName.consume.start.timestamp` in hive and query.
   
   Also, `hoodie.datasource.write.database.name` and `hoodie.database.name` can 
reuse in other scene.
   
   @xushiyan what do you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to