xiarixiaoyao commented on a change in pull request #4478:
URL: https://github.com/apache/hudi/pull/4478#discussion_r776914536
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeCompactedRecordReader.java
##########
@@ -193,6 +195,7 @@ public void close() throws IOException {
// need clean the tmp file which created by logScanner
// Otherwise, for resident process such as presto, the /tmp directory will
overflow
((ExternalSpillableMap) deltaRecordMap).close();
+ mergedLogRecordScanner.close();
Review comment:
minor comment： maybe we can remove line197， since
mergedLogRecordScanner.close() will call ((ExternalSpillableMap)
deltaRecordMap).close() internal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
