manojpec commented on a change in pull request #4449:
URL: https://github.com/apache/hudi/pull/4449#discussion_r785240599
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java
##########
@@ -83,6 +84,11 @@
.withDocumentation("Lower values increase the size of metadata tracked
within HFile, but can offer potentially "
+ "faster lookup times.");
+ public static final ConfigProperty<String> HFILE_SCHEMA_KEY_FIELD_ID =
ConfigProperty
+ .key("hoodie.hfile.schema.key.field.id")
+ .defaultValue(HoodieMetadataPayload.SCHEMA_FIELD_ID_KEY)
Review comment:
fixed.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java
##########
@@ -83,6 +84,11 @@
.withDocumentation("Lower values increase the size of metadata tracked
within HFile, but can offer potentially "
+ "faster lookup times.");
+ public static final ConfigProperty<String> HFILE_SCHEMA_KEY_FIELD_ID =
ConfigProperty
+ .key("hoodie.hfile.schema.key.field.id")
+ .defaultValue(HoodieMetadataPayload.SCHEMA_FIELD_ID_KEY)
+ .withDocumentation("Key field name for the HFile schema. This key field
is used for on-disk storage optimization");
Review comment:
fixed.
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java
##########
@@ -110,8 +106,8 @@ public HoodieLogBlockType getBlockType() {
boolean useIntegerKey = false;
int key = 0;
int keySize = 0;
- Field keyField = records.get(0).getSchema().getField(this.keyField);
- if (keyField == null) {
+ final Field schemaKeyField =
records.get(0).getSchema().getField(HoodieMetadataPayload.SCHEMA_FIELD_ID_KEY);
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
