imbajin commented on code in PR #104:
URL:
https://github.com/apache/incubator-hugegraph-commons/pull/104#discussion_r960714456
##########
style/checkstyle.xml:
##########
@@ -24,16 +24,6 @@
<property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
<message key="name.invalidPattern" value="Package name ''{0}''
must match pattern ''{1}''."/>
</module>
- <!-- <module name="ImportOrder">-->
- <!-- <property name="staticGroups"-->
- <!--
value="org.apache,java,javax,org,com,com.baidu.hugegraph"/>-->
- <!-- <property name="separatedStaticGroups"
value="true"/>-->
- <!-- <property name="groups"
value="org.apache,java,javax,org,com,com.baidu.hugegraph"/>-->
- <!-- <property name="ordered" value="true"/>-->
- <!-- <property name="separated" value="true"/>-->
- <!-- <property name="option" value="top"/>-->
- <!-- <property name="sortStaticImportsAlphabetically"
value="true"/>-->
- <!-- </module>-->
Review Comment:
need it?
##########
hugegraph-common/src/test/java/org/apache/hugegraph/unit/UnitTestSuite.java:
##########
@@ -0,0 +1,127 @@
+/*
+ * Copyright 2017 HugeGraph Authors
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hugegraph.unit;
Review Comment:
seems this file should be treat as move `a -> a'` (not remove & add?)
maybe try `git mv` for this file
##########
hugegraph-common/src/test/java/org/apache/hugegraph/unit/util/StringUtilTest.java:
##########
@@ -17,16 +17,16 @@
* under the License.
*/
-package com.baidu.hugegraph.unit.util;
+package org.apache.hugegraph.unit.util;
import java.util.ArrayList;
import java.util.List;
+import org.apache.hugegraph.util.StringUtil;
+import org.apache.hugegraph.util.StringUtil.Chars;
import org.junit.Test;
-import com.baidu.hugegraph.testutil.Assert;
-import com.baidu.hugegraph.util.StringUtil;
-import com.baidu.hugegraph.util.StringUtil.Chars;
+import org.apache.hugegraph.testutil.Assert;
Review Comment:
should `25~26 + 29` be together?
or we need use check-style plugin to auto format it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
