imbajin commented on code in PR #104:
URL:
https://github.com/apache/incubator-hugegraph-commons/pull/104#discussion_r963037412
##########
style/checkstyle.xml:
##########
@@ -24,16 +24,6 @@
<property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
<message key="name.invalidPattern" value="Package name ''{0}''
must match pattern ''{1}''."/>
</module>
- <!-- <module name="ImportOrder">-->
- <!-- <property name="staticGroups"-->
- <!--
value="org.apache,java,javax,org,com,com.baidu.hugegraph"/>-->
- <!-- <property name="separatedStaticGroups"
value="true"/>-->
- <!-- <property name="groups"
value="org.apache,java,javax,org,com,com.baidu.hugegraph"/>-->
- <!-- <property name="ordered" value="true"/>-->
- <!-- <property name="separated" value="true"/>-->
- <!-- <property name="option" value="top"/>-->
- <!-- <property name="sortStaticImportsAlphabetically"
value="true"/>-->
- <!-- </module>-->
Review Comment:
@simon824 shall we keep it & run them in ci automatically?
and could we auto format the code? (or use some `mvn xxx` command to check
it?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
