marvin-hansen commented on issue #1873: URL: https://github.com/apache/iggy/issues/1873#issuecomment-2979240803
Thank you @vax-r Looks good to me. Fundamentally, the I way I approach this kind of change is the following process: 1) Write a new abstraction i.e. IggyClientStatic while keeping the rest as is. 2) Make sure the code compiles, works as expexted and passes some basic tests. 3) Remove the previous type and then rename IggyClientStatic to IggyClient - Then is when code breaks and test fails 4) Mop up the breaking changes, one crate at a time. If possible, use automated code rewrite i.e. ask ChatGPT or gemini to write you as script to re-write the most common cases. Then, take care of whatever the re-write couldn't handle. By experience, this ranges between 5% to 25% of all cases. 5) Run rustfmt, clippy and double check that all tests pass 2 or 3 times to catch flaky ones. LMK if any questions come up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
