marvin-hansen commented on issue #1873: URL: https://github.com/apache/iggy/issues/1873#issuecomment-2984951621
Sounds about right. - with_client can go - IggyClientBuilder<your_type> is good. I'm a big fan of seperate impl blocks and use them all the time. Go for it. On Thu, Jun 19, 2025 at 00:26 I-Hsin Cheng ***@***.***> wrote: > *vax-r* left a comment (apache/iggy#1873) > <https://github.com/apache/iggy/issues/1873#issuecomment-2984919495> > > Plus, with_client() should no longer be needed right ? > I've browse through some use cases , when we switched to static > dispatched, the type of client should be known at compile-time, there's > no need to use with_client() to create ClientBuilder with certain type, > just write IggyClientBuilder<your_type> . > > That's my understanding. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iggy/issues/1873#issuecomment-2984919495>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFYR7XBR6NMWMNOA74AR2LD3EGHLHAVCNFSM6AAAAAB7O4L4SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBUHEYTSNBZGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
