chengxilo commented on code in PR #1995: URL: https://github.com/apache/iggy/pull/1995#discussion_r2198529745
########## foreign/go/contracts/identifier.go: ########## Review Comment: I choose to use two seperate function to create new Identifier with Numeric and String. This make sure that user would not use int, int32, uint8 etc as the value of identifier and casue some problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
