chengxilo commented on PR #1995: URL: https://github.com/apache/iggy/pull/1995#issuecomment-3063402086
I didn't change the value type of Length in this PR, I will explain why it should be addressed in the future. For now, I’ve left it as int to ensure the Go SDK can still compile. In the future, we need to provide a function like this to Identifier: https://github.com/apache/iggy/blob/09f608fe961df351b24231fdc32605b2d8124bdd/core/common/src/types/identifier/mod.rs#L211-L213 The return type should be uint64, similar to how IggyByteSize is implemented in the Rust SDK: https://github.com/apache/iggy/blob/master/core/common/src/utils/byte_size.rs The entire byte size calculation logic—not just for Identifier—needs to be updated. Currently, we calculate all byte sizes using int, but uint64 would be more appropriate (because rust sdk use uint64). That said, this change would require touching thousands of lines of code across the project, so I believe it’s best handled in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
