gunli commented on code in PR #11872:
URL: https://github.com/apache/inlong/pull/11872#discussion_r2103653977
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/util/id.go:
##########
@@ -29,12 +29,14 @@ var (
)
func init() {
+ var id uint32 = 0
+
+ // Generate the ID from an IP if possible.
ip, err := GetOneIP()
- if err != nil {
- log.Fatal(err)
Review Comment:
Hi @marcv81, It is a really good update, but I think `initSnowFlake()` need
to be synchronized with some mechanisms like `sync.Once` as it can be called by
concurrent goroutines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
