gunli commented on code in PR #11872:
URL: https://github.com/apache/inlong/pull/11872#discussion_r2108043993
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/util/id.go:
##########
@@ -29,12 +29,14 @@ var (
)
func init() {
+ var id uint32 = 0
+
+ // Generate the ID from an IP if possible.
ip, err := GetOneIP()
- if err != nil {
- log.Fatal(err)
Review Comment:
Hi @marcv81 , thanks for your update. I think this is overkill, in big data
area, we may send/report a lot of data in 1s, if we use SnowFlakeID as the
batchID, it is a frequently call, `Lock` is inefficient. Besides, let it failed
at the beginning and succeed later is not good for data consistency, it is
better to fail fast at the beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
