This is an automated email from the ASF dual-hosted git repository.
jamesbognar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git
The following commit(s) were added to refs/heads/master by this push:
new 1f1e9455d9 SonarQube bug fixes
1f1e9455d9 is described below
commit 1f1e9455d9fd3db842f7bf75851db59d4c78180c
Author: James Bognar <[email protected]>
AuthorDate: Wed Feb 18 08:33:08 2026 -0500
SonarQube bug fixes
---
.../java/org/apache/juneau/commons/utils/ResourceBundleUtils.java | 4 +++-
.../src/main/java/org/apache/juneau/httppart/HttpPartSchema.java | 1 +
.../src/main/java/org/apache/juneau/xml/XmlSerializerSession.java | 4 +++-
.../org/apache/juneau/microservice/jetty/JettyMicroservice.java | 8 ++++++--
.../src/main/java/org/apache/juneau/rest/client/RestClient.java | 1 +
.../java/org/apache/juneau/rest/logger/CallLoggingDetail.java | 4 +++-
6 files changed, 17 insertions(+), 5 deletions(-)
diff --git
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/utils/ResourceBundleUtils.java
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/utils/ResourceBundleUtils.java
index e9ef94bad5..96d344dd32 100644
---
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/utils/ResourceBundleUtils.java
+++
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/utils/ResourceBundleUtils.java
@@ -47,7 +47,9 @@ public class ResourceBundleUtils {
assertArgNotNull(ARG_loader, loader);
try {
return ResourceBundle.getBundle(baseName, locale,
loader);
- } catch (@SuppressWarnings("unused") MissingResourceException
e) {}
+ } catch (@SuppressWarnings("unused") MissingResourceException
e) {
+ // Resource bundle not found, return null
+ }
return null;
}
}
\ No newline at end of file
diff --git
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/httppart/HttpPartSchema.java
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/httppart/HttpPartSchema.java
index 4d41325ecd..f3f5876b2f 100644
---
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/httppart/HttpPartSchema.java
+++
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/httppart/HttpPartSchema.java
@@ -4363,6 +4363,7 @@ public class HttpPartSchema {
if (! isValidMultipleOf(n))
throw new
SchemaValidationException("Multiple-of not met.");
}
+ // If not a number, skip validation (validation
only applies to number types)
break;
}
case OBJECT: {
diff --git
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/xml/XmlSerializerSession.java
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/xml/XmlSerializerSession.java
index 6eb4d0372b..e42396ca55 100644
---
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/xml/XmlSerializerSession.java
+++
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/xml/XmlSerializerSession.java
@@ -482,7 +482,9 @@ public class XmlSerializerSession extends
WriterSerializerSession {
// Serialize XML content.
if (nn(content)) {
out.w('>').nlIf(! isMixedOrText, indent);
- if (contentType == null) {} else if
(contentType.isCollection()) {
+ if (contentType == null) {
+ // No content type specified - skip content
serialization
+ } else if (contentType.isCollection()) {
var c = (Collection)content;
boolean previousWasTextNode = false;
for (var value : c) {
diff --git
a/juneau-microservice/juneau-microservice-jetty/src/main/java/org/apache/juneau/microservice/jetty/JettyMicroservice.java
b/juneau-microservice/juneau-microservice-jetty/src/main/java/org/apache/juneau/microservice/jetty/JettyMicroservice.java
index 7e04a2694c..5bca4dfd99 100644
---
a/juneau-microservice/juneau-microservice-jetty/src/main/java/org/apache/juneau/microservice/jetty/JettyMicroservice.java
+++
b/juneau-microservice/juneau-microservice-jetty/src/main/java/org/apache/juneau/microservice/jetty/JettyMicroservice.java
@@ -448,7 +448,9 @@ public class JettyMicroservice extends Microservice {
port = RANDOM.nextInt(32767 - ports[0] + 1) +
ports[0];
try (var ss = new ServerSocket(port)) {
return port;
- } catch (@SuppressWarnings("unused") IOException e) {}
+ } catch (@SuppressWarnings("unused") IOException e) {
+ // Port is in use, try next port in array
+ }
}
return 0;
}
@@ -653,7 +655,9 @@ public class JettyMicroservice extends Microservice {
String hostname = "localhost";
try {
hostname = InetAddress.getLocalHost().getHostName();
- } catch (@SuppressWarnings("unused") UnknownHostException e) {}
+ } catch (@SuppressWarnings("unused") UnknownHostException e) {
+ // Cannot determine hostname, use default "localhost"
+ }
return hostname;
}
diff --git
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/RestClient.java
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/RestClient.java
index fb91f8d903..a4f3b7eabb 100644
---
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/RestClient.java
+++
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/RestClient.java
@@ -6392,6 +6392,7 @@ public class RestClient extends BeanContextable
implements HttpClient, Closeable
httpClient.close();
if (nn(es) && executorServiceShutdownOnClose)
es.shutdown();
+ // If executorServiceShutdownOnClose is false, executor service
remains open for reuse
if (nn(creationStack))
closedStack = Thread.currentThread().getStackTrace();
}
diff --git
a/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/logger/CallLoggingDetail.java
b/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/logger/CallLoggingDetail.java
index faa534f095..9e67002068 100644
---
a/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/logger/CallLoggingDetail.java
+++
b/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/logger/CallLoggingDetail.java
@@ -52,7 +52,9 @@ public enum CallLoggingDetail {
if (ne(s)) {
try {
return valueOf(s.toUpperCase());
- } catch (@SuppressWarnings("unused")
IllegalArgumentException e) {}
+ } catch (@SuppressWarnings("unused")
IllegalArgumentException e) {
+ // Invalid enum value - return null below
+ }
}
return null;
}