rovarga commented on code in PR #2627:
URL: https://github.com/apache/karaf/pull/2627#discussion_r3176973925
##########
bundle/core/src/main/java/org/apache/karaf/bundle/core/internal/BundleWatcherImpl.java:
##########
@@ -138,12 +138,12 @@ public void run() {
}
}
- private String getLocation(Bundle bundle) {
+ private static String getLocation(Bundle bundle) {
Review Comment:
Reviewing the state of that upcoming patch: there are a few other
conversions, but strictly in files which are also touched by the NIO2
conversion.
So it's up to you:
- I can update this PR with the follow-up statics
- I can raise a separate PR for just the next round (i.e. delta on top of
this PR)
- I can just keep them in the NIO2 patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
