ricardozanini commented on code in PR #255:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/255#discussion_r1335980246
##########
api/v1alpha08/sonataflow_types.go:
##########
@@ -24,6 +24,535 @@ import (
"github.com/kiegroup/kogito-serverless-operator/api"
)
+const DefaultContainerName = "workflow"
+
+// FlowContainer is the container for the internal workflow deployment based
on the default Kubernetes Container API
+type FlowContainer struct {
+ // Container image name.
+ // More info: https://kubernetes.io/docs/concepts/containers/images
+ // This field is optional to allow higher level config management to
default or override
+ // container images in workload controllers like Deployments and
StatefulSets.
+ // +optional
+ Image string `json:"image,omitempty" protobuf:"bytes,2,opt,name=image"`
Review Comment:
Hey @wmedvede thanks for the question. Please see
[https://issues.redhat.com/browse/KOGITO-9833](KOGITO-9833) where I summarize
the fix for this problem. This is the first question one will have once it
tries this feature. The operator uses the `spec.flow` to do any configurations
like discovery and eventing objects creation. So if one sets an image that is
not compatible, it happens to have a bad deployment in the end. But we will do
an integrity check before deploying it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
