ricardozanini commented on code in PR #255: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/255#discussion_r1336015565
########## test/testdata/sonataflow.org_v1alpha08_sonataflow-simpleops.yaml: ########## @@ -0,0 +1,33 @@ +# Copyright 2023 Red Hat, Inc. and/or its affiliates +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: sonataflow.org/v1alpha08 +kind: SonataFlow +metadata: + name: simple + annotations: + sonataflow.org/description: Simple example on k8s! + sonataflow.org/version: 0.0.1 +spec: + podSpecTemplate: + flowContainer: + image: quay.io/kiegroup/sonataflow-minimal-example:latest Review Comment: > Maybe I'm missing something, but I see this very risky, and other than a kind of optimization I don't see the use cases for this. ¿? @wmedvede I believe I replied to your questions in the other comment. As far as this one, we can't control the build process. Users might have really strict and particular requirements when building images such as hardening, security issues, company policies, and so on. Opening an API to enable custom builds in the operator can be quite challenging and it's not our core. The build system today is simple enough for really small/simple use cases, but we can't scale. For this reason, we explore the `PodSpec` for users to set their image built externally. As I said, we will add an integrity check to the image as we progress avoiding this kind of disruption. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
