fjtirado commented on code in PR #3403:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3403#discussion_r1533692995
##########
jbpm/process-serialization-protobuf/src/main/java/org/jbpm/flow/serialization/ProcessInstanceMarshallerService.java:
##########
@@ -65,6 +67,15 @@ public <T> Builder
withContextEntries(Map<MarshallerContextName<T>, T> contextEn
return this;
}
+ public Builder withDefaultListeners() {
Review Comment:
A philosophycal discussion for other builders.
I think that builders should not enforce the call of default methods. So in
my opinion this logic belongs to the build method and should only be executed
if withListeners method has not been invoked before invoking build.
That way, you save having to call withDefaultListeners to all builders
instance that not need specific listeners (in the case of this PR you save
changing 4 addons)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
