jomarko opened a new pull request, #2254:
URL: https://github.com/apache/incubator-kie-tools/pull/2254
In this PR we address apache/incubator-kie-issues#1074 and
apache/incubator-kie-issues#1075 as both are tightly related.
Summary of this PR is:
- 1074: We prevent user from setting width/height lower than minimal size
allowed, the problem is, user can not type the value manually. Because when he
start to type the number, each one-digit number is lower than minimal boundary,
at least two-digit number. Using the number input box control (arrow up and
down) is working and user can change the value. To overcome this I tried to use
- `onBlur` instead of the `onChange` however it seems no 'commit' was
invoked, I was not able to get it working, maybe, do we have an working
`onBlur` example in our codebase?
- `debounce` here it was again not working ideally. I was able to replace
`onWidthChange` with `debouncedWidthChange`, but maybe I was using it wrongly,
again, maybe some link for working example in our codebase?
- 1075: This PR further unify the position of the 'Reset font' and 'Reset
shape' buttons.
- 1075: This PR fixes 'Reset shape' button only for a scenario, when single
node is on canvas. There is an issue also on main, when multiple nodes are on
the canvas, the 'Reset shape' button does not work at all.
- TODO: Playwright tests, once we agree how to solve
apache/incubator-kie-issues#1074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
