jomarko commented on code in PR #2254:
URL:
https://github.com/apache/incubator-kie-tools/pull/2254#discussion_r1576513709
##########
packages/dmn-editor/src/propertiesPanel/ShapeOptions.tsx:
##########
@@ -63,6 +68,9 @@ export function ShapeOptions({
const boundPositionX = useMemo(() => +(shapeBound?.["@_x"]?.toFixed(2) ??
""), [shapeBound]);
const boundPositionY = useMemo(() => +(shapeBound?.["@_y"]?.toFixed(2) ??
""), [shapeBound]);
+ const [width, setWidth] = useState<number>(boundWidth);
+ const [height, setHeight] = useState<number>(boundHeight);
Review Comment:
This is now the only issue, imagine a scenario:
- two nodes added to the canvas
- open properties panel
- select first node
- change its width or height
- **keep properties panel open and select second node**
- the properties panel is all correctly updated, but **width** and
**height** are not, the values of the first node are shown
If we do click diagram between node selection or we close and reopen
properties panel, correct **width** and **height** are initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
