yurloc commented on code in PR #5876:
URL:
https://github.com/apache/incubator-kie-drools/pull/5876#discussion_r1583845505
##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLParser.g4:
##########
@@ -409,6 +413,26 @@ lhsAccumulate : (DRL_ACCUMULATE|DRL_ACC) LPAREN lhsAndDef
(COMMA|SEMI)
RPAREN (SEMI)?
;
+/**
+ * lhsGroupBy := GROUPBY LEFT_PAREN lhsAnd (COMMA|SEMICOLON)
+ * groupByKeyBinding SEMICOLON
+ * accumulateFunctionBinding (COMMA
accumulateFunctionBinding)*
+ * (SEMICOLON constraints)?
+ * RIGHT_PAREN SEMICOLON?
+ */
Review Comment:
Sure, this no longer makes sense. I've included it for consistency with how
the new parser has been developed but these rule comments from the old parser
are either outdated and therefore wrong or they are correct in which case the
new rule is often identical, making them redundant.
I suppose we're going to remove the other ones as well as part of the
post-development cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
