tkobayas commented on code in PR #5876:
URL:
https://github.com/apache/incubator-kie-drools/pull/5876#discussion_r1584151085
##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLParser.g4:
##########
@@ -409,6 +413,26 @@ lhsAccumulate : (DRL_ACCUMULATE|DRL_ACC) LPAREN lhsAndDef
(COMMA|SEMI)
RPAREN (SEMI)?
;
+/**
+ * lhsGroupBy := GROUPBY LEFT_PAREN lhsAnd (COMMA|SEMICOLON)
+ * groupByKeyBinding SEMICOLON
+ * accumulateFunctionBinding (COMMA
accumulateFunctionBinding)*
+ * (SEMICOLON constraints)?
+ * RIGHT_PAREN SEMICOLON?
+ */
Review Comment:
Yeah, the comment from old parser would be useful when we hit an issue and
check the first clue of how old parser works. In reality, we often need to
debug DRL6Parser eventually, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
