jianrongzhang89 commented on code in PR #540:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/540#discussion_r1775164534
##########
Makefile:
##########
@@ -366,6 +368,16 @@ deploy-knative: create-cluster
kubectl wait --for=condition=Ready=True KnativeServing/knative-serving
-n knative-serving --timeout=$(TIMEOUT_SECS)
kubectl wait --for=condition=Ready=True
KnativeEventing/knative-eventing -n knative-eventing --timeout=$(TIMEOUT_SECS)
+.PHONY: deploy-monitoring
+deploy-monitoring: create-cluster
Review Comment:
Instead of dropping grafana, we can move it to a separate target. It will
not be used by e2e, but is useful for documenting the grafana related
information. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
