jianrongzhang89 commented on code in PR #540:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/540#discussion_r1797319497


##########
internal/controller/profiles/common/object_creators.go:
##########
@@ -272,6 +278,29 @@ func ServiceCreator(workflow *operatorapi.SonataFlow) 
(client.Object, error) {
        return service, nil
 }
 
+// KnativeMetricsServiceCreator is an objectCreator for a kubernetes service 
for exposing prometheus metrics for serverless workflows.
+// It maps the default HTTP port (80) to the target Java application webserver 
on port 8080.
+func KnativeMetricsServiceCreator(workflow *operatorapi.SonataFlow) 
(client.Object, error) {
+       lbl := workflowproj.GetMergedLabels(workflow)
+       service := &corev1.Service{
+               ObjectMeta: metav1.ObjectMeta{
+                       Name:      fmt.Sprintf("%s-metrics", workflow.Name), // 
default service name is already used by knaitve service

Review Comment:
   > 
   
   This part has been deleted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to