ricardozanini commented on code in PR #2754:
URL:
https://github.com/apache/incubator-kie-tools/pull/2754#discussion_r1850979952
##########
packages/sonataflow-image-common/env/index.js:
##########
@@ -17,11 +17,20 @@
* under the License.
*/
-const { varsWithName, composeEnv } = require("@kie-tools-scripts/build-env");
+const { varsWithName, getOrDefault, composeEnv } =
require("@kie-tools-scripts/build-env");
module.exports = composeEnv([require("@kie-tools/root-env/env")], {
- vars: varsWithName({}),
+ vars: varsWithName({
+ QUARKUS_PLATFORM_groupId: {
Review Comment:
```suggestion
SONATAFLOW_IMAGE__quarkusGroupId: {
```
##########
packages/sonataflow-management-console-image-env/env/index.js:
##########
@@ -43,6 +44,10 @@ module.exports = composeEnv([rootEnv], {
default: 8080,
description: "The internal container port.",
},
+ SONATAFLOW_MANAGEMENT_CONSOLE__quarkusPlatformGroupId: {
+ default: sonataflowImageCommonEnv.env.quarkus.groupId,
+ description: "Quarkus platform group id.",
+ },
Review Comment:
```suggestion
```
##########
packages/sonataflow-management-console-image-env/env/index.js:
##########
@@ -20,6 +20,7 @@
const { varsWithName, getOrDefault, composeEnv } =
require("@kie-tools-scripts/build-env");
const rootEnv = require("@kie-tools/root-env/env");
+const sonataflowImageCommonEnv =
require("@kie-tools/sonataflow-image-common/env");
module.exports = composeEnv([rootEnv], {
Review Comment:
```suggestion
module.exports = composeEnv([rootEnv, sonataflowImageCommonEnv], {
```
##########
packages/sonataflow-management-console-image-env/env/index.js:
##########
@@ -52,6 +57,7 @@ module.exports = composeEnv([rootEnv], {
name: getOrDefault(this.vars.SONATAFLOW_MANAGEMENT_CONSOLE__name),
buildTag:
getOrDefault(this.vars.SONATAFLOW_MANAGEMENT_CONSOLE__buildTag),
port: getOrDefault(this.vars.SONATAFLOW_MANAGEMENT_CONSOLE__port),
+ quarkusGroupId:
getOrDefault(this.vars.SONATAFLOW_MANAGEMENT_CONSOLE__quarkusPlatformGroupId),
Review Comment:
```suggestion
```
##########
packages/sonataflow-management-console-image/package.json:
##########
@@ -28,7 +28,7 @@
"image:cekit:build:linux": "pnpm image:cekit:copy && pnpm
image:cekit:setup:env make -C ./dist-dev build",
"image:cekit:build:win32:darwin": "echo \"Build skipped on macOS and
Windows\"",
"image:cekit:copy": "cp -R
./node_modules/@kie-tools/sonataflow-image-common/resources/* ./dist-dev/ && cp
-R resources/* ./dist-dev/",
- "image:cekit:setup:env": ".
./node_modules/@kie-tools/python-venv/venv/bin/activate && cross-env
KOGITO_IMAGE_REGISTRY=$(build-env sonataflowManagementConsoleImageEnv.registry)
KOGITO_IMAGE_REGISTRY_ACCOUNT=$(build-env
sonataflowManagementConsoleImageEnv.account) KOGITO_IMAGE_NAME=$(build-env
sonataflowManagementConsoleImageEnv.name) KOGITO_IMAGE_TAG=$(build-env
sonataflowManagementConsoleImageEnv.buildTag)
QUARKUS_PLATFORM_VERSION=$(build-env versions.quarkus)
KOGITO_VERSION=$(build-env versions.kogito)
SONATAFLOW_MANAGEMENT_CONSOLE_PORT=$(build-env
sonataflowManagementConsoleImageEnv.port)"
+ "image:cekit:setup:env": ".
./node_modules/@kie-tools/python-venv/venv/bin/activate && cross-env
KOGITO_IMAGE_REGISTRY=$(build-env sonataflowManagementConsoleImageEnv.registry)
KOGITO_IMAGE_REGISTRY_ACCOUNT=$(build-env
sonataflowManagementConsoleImageEnv.account) KOGITO_IMAGE_NAME=$(build-env
sonataflowManagementConsoleImageEnv.name) KOGITO_IMAGE_TAG=$(build-env
sonataflowManagementConsoleImageEnv.buildTag)
QUARKUS_PLATFORM_GROUPID=$(build-env
sonataflowManagementConsoleImageEnv.quarkusGroupId)
QUARKUS_PLATFORM_VERSION=$(build-env versions.quarkus)
KOGITO_VERSION=$(build-env versions.kogito)
SONATAFLOW_MANAGEMENT_CONSOLE_PORT=$(build-env
sonataflowManagementConsoleImageEnv.port)"
Review Comment:
```suggestion
"image:cekit:setup:env": ".
./node_modules/@kie-tools/python-venv/venv/bin/activate && cross-env
KOGITO_IMAGE_REGISTRY=$(build-env sonataflowManagementConsoleImageEnv.registry)
KOGITO_IMAGE_REGISTRY_ACCOUNT=$(build-env
sonataflowManagementConsoleImageEnv.account) KOGITO_IMAGE_NAME=$(build-env
sonataflowManagementConsoleImageEnv.name) KOGITO_IMAGE_TAG=$(build-env
sonataflowManagementConsoleImageEnv.buildTag)
QUARKUS_PLATFORM_GROUPID=$(build-env sonataFlowImage.quarkusGroupId)
QUARKUS_PLATFORM_VERSION=$(build-env versions.quarkus)
KOGITO_VERSION=$(build-env versions.kogito)
SONATAFLOW_MANAGEMENT_CONSOLE_PORT=$(build-env
sonataflowManagementConsoleImageEnv.port)"
```
##########
packages/sonataflow-image-common/env/index.js:
##########
@@ -17,11 +17,20 @@
* under the License.
*/
-const { varsWithName, composeEnv } = require("@kie-tools-scripts/build-env");
+const { varsWithName, getOrDefault, composeEnv } =
require("@kie-tools-scripts/build-env");
module.exports = composeEnv([require("@kie-tools/root-env/env")], {
- vars: varsWithName({}),
+ vars: varsWithName({
+ QUARKUS_PLATFORM_groupId: {
+ default: "io.quarkus.platform",
+ description: "Quarkus platform group id.",
+ },
+ }),
get env() {
- return {};
+ return {
+ quarkus: {
+ groupId: getOrDefault(this.vars.QUARKUS_PLATFORM_groupId),
Review Comment:
```suggestion
sonataFlowImage: {
quarkusGroupId:
getOrDefault(this.vars.SONATAFLOW_IMAGE__quarkusGroupId),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
