ricardozanini commented on code in PR #2754:
URL:
https://github.com/apache/incubator-kie-tools/pull/2754#discussion_r1851007496
##########
packages/sonataflow-image-common/env/index.js:
##########
@@ -17,11 +17,20 @@
* under the License.
*/
-const { varsWithName, composeEnv } = require("@kie-tools-scripts/build-env");
+const { varsWithName, getOrDefault, composeEnv } =
require("@kie-tools-scripts/build-env");
module.exports = composeEnv([require("@kie-tools/root-env/env")], {
- vars: varsWithName({}),
+ vars: varsWithName({
+ SONATAFLOW_IMAGE__quarkusGroupId: {
+ default: "io.quarkus.platform",
+ description: "Quarkus platform group id.",
+ },
+ }),
get env() {
- return {};
+ return {
+ sonataFlowImage: {
+ quarkusGroupId:
getOrDefault(this.vars.SONATAFLOW_IMAGE__quarkusGroupId),
Review Comment:
```suggestion
quarkusGroupId:
getOrDefault(this.vars.KOGITO_IMAGES_CEKIT_MODULES__quarkusGroupId),
```
##########
packages/sonataflow-image-common/env/index.js:
##########
@@ -17,11 +17,20 @@
* under the License.
*/
-const { varsWithName, composeEnv } = require("@kie-tools-scripts/build-env");
+const { varsWithName, getOrDefault, composeEnv } =
require("@kie-tools-scripts/build-env");
module.exports = composeEnv([require("@kie-tools/root-env/env")], {
- vars: varsWithName({}),
+ vars: varsWithName({
+ SONATAFLOW_IMAGE__quarkusGroupId: {
+ default: "io.quarkus.platform",
+ description: "Quarkus platform group id.",
+ },
+ }),
get env() {
- return {};
+ return {
+ sonataFlowImage: {
Review Comment:
```suggestion
kogitoImagesCekitModules: {
```
##########
packages/sonataflow-image-common/env/index.js:
##########
@@ -17,11 +17,20 @@
* under the License.
*/
-const { varsWithName, composeEnv } = require("@kie-tools-scripts/build-env");
+const { varsWithName, getOrDefault, composeEnv } =
require("@kie-tools-scripts/build-env");
module.exports = composeEnv([require("@kie-tools/root-env/env")], {
- vars: varsWithName({}),
+ vars: varsWithName({
+ SONATAFLOW_IMAGE__quarkusGroupId: {
Review Comment:
```suggestion
KOGITO_IMAGES_CEKIT_MODULES__quarkusGroupId: {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
