wmedvede commented on code in PR #2166:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893879010
##########
data-index/data-index-graphql/src/main/java/org/kie/kogito/index/graphql/AbstractGraphQLSchemaManager.java:
##########
@@ -69,8 +68,6 @@ public abstract class AbstractGraphQLSchemaManager implements
GraphQLSchemaManag
private static final String UNABLE_TO_FIND_ERROR_MSG = "Unable to find the
instance with %s %s";
- private static final Logger LOGGER =
LoggerFactory.getLogger(AbstractGraphQLSchemaManager.class);
Review Comment:
see former example LOGGER here :smile:
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed",
"Aborted");
+ private static final Logger logger =
LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
I'd prefer call his LOGGER
##########
data-index/data-index-graphql/src/main/java/org/kie/kogito/index/graphql/AbstractGraphQLSchemaManager.java:
##########
@@ -92,14 +92,17 @@ public void setup() {
(GraphQLInputObjectType) schema.getType("JobArgument"));
}
+ protected final void loadAdditionalMutations(Builder builder) {
+ mutations.stream().map(m -> m.mutations(this)).flatMap(map ->
map.entrySet().stream())
Review Comment:
Maybe a log trace can help identify in the future which additional mutations
were loaded in current server. :thinking:
##########
data-index/data-index-mutations/data-index-shared-output-mutation/src/main/java/org/kie/kogito/index/mutations/OutputGraphQLMutationProvider.java:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.kogito.index.mutations;
+
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+import org.kie.kogito.index.CommonUtils;
+import org.kie.kogito.index.api.ExecuteArgs;
+import org.kie.kogito.index.graphql.AbstractGraphQLSchemaManager;
+import org.kie.kogito.index.graphql.GraphQLMutationsProvider;
+import org.kie.kogito.index.model.ProcessDefinition;
+import org.kie.kogito.index.model.ProcessDefinitionKey;
+import org.kie.kogito.index.model.ProcessInstance;
+import org.kie.kogito.index.storage.DataIndexStorageService;
+import org.kie.kogito.jackson.utils.JsonObjectUtils;
+import org.kie.kogito.jackson.utils.MergeUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.fasterxml.jackson.databind.JsonNode;
+
+import graphql.schema.DataFetcher;
+import graphql.schema.DataFetchingEnvironment;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
+public class OutputGraphQLMutationProvider implements GraphQLMutationsProvider
{
+
+ private static Logger logger =
LoggerFactory.getLogger(OutputGraphQLMutationProvider.class);
Review Comment:
LOGGER ?
##########
data-index/data-index-service/data-index-service-common/src/main/java/org/kie/kogito/index/service/api/KogitoRuntimeClientImpl.java:
##########
@@ -72,6 +75,17 @@ class KogitoRuntimeClientImpl extends
KogitoRuntimeCommonClient implements Kogit
private static final Logger LOGGER =
LoggerFactory.getLogger(KogitoRuntimeClientImpl.class);
Review Comment:
LOGGER :heart:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
