fjtirado commented on code in PR #2166:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2166#discussion_r1893892372
##########
data-index/data-index-common/src/main/java/org/kie/kogito/index/CommonUtils.java:
##########
@@ -18,15 +18,56 @@
*/
package org.kie.kogito.index;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.Set;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import graphql.schema.idl.SchemaParser;
+import graphql.schema.idl.TypeDefinitionRegistry;
+
public class CommonUtils {
public static final int ERROR_STATE = 5;
private static final Set<String> finalStates = Set.of("Completed",
"Aborted");
+ private static final Logger logger =
LoggerFactory.getLogger(CommonUtils.class);
Review Comment:
I prefer logger, according to this
https://stackoverflow.com/a/12069687/16843807, which refers to the proper
section of Java coding style
I know we are using both in our codebase (according to the taste of each
developer), so my policy is to not change the ones already existing, but if
adding a new one, use the lowercase form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
