gitgabrio opened a new pull request, #6213: URL: https://github.com/apache/incubator-kie-drools/pull/6213
Fixes https://github.com/apache/incubator-kie-issues/issues/1742 The B-FEEL proposal simply define a list of "default" values to return when the standard FEEL would return `null` This PR: 1. create the `FEELDialect` enum to define different feel dialects, for the moment being the "standard" one and the B-FEEL one 2. populate the evaluation context with the current feel dialect 3. define `Object defaultValue() ` and `List emendedList(List toEmend)` inside `FEELFunction`, to be override on specifc needs by concrete implementation 4. returns the result of the above methods in when the original result is null and the dialect is B-FEEL 5. add a specific BFEELTest to verify the cases listed in the B-FEEL proposal The PR touched lot of files due to the pervasiveness of the logic, but the design itself seems clear, at least to me. @AthiraHari77 @bncriju <details> <summary> How to replicate CI configuration locally? </summary> Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it. </details> <details> <summary> How to retest this PR or trigger a specific build: </summary> - for <b>pull request and downstream checks</b> - Push a new commit to the PR. An empty commit would be enough. - for a <b>full downstream build</b> - for <b>github actions</b> job: add the label `run_fdb` - for <b>Jenkins PR check only</b> - If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org For additional commands, e-mail: commits-h...@kie.apache.org
