baldimir commented on code in PR #6213:
URL:
https://github.com/apache/incubator-kie-drools/pull/6213#discussion_r1916392345
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/ListContainsFunction.java:
##########
@@ -56,7 +57,8 @@ public static boolean itemEqualsSC(Object value, Object
itemFromList) {
if (value instanceof String) {
return value.equals(itemFromList);
} else {
- Boolean dmnEqual = BooleanEvalHelper.isEqual(value, itemFromList);
+ // Defaulting FEELDialect to FEEL
+ Boolean dmnEqual = BooleanEvalHelper.isEqual(value, itemFromList,
FEELDialect.FEEL);
Review Comment:
The logic should apply to all functions returning a boolean. So if it is
missing on list contains, it should be added there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
