yesamer commented on code in PR #6389:
URL:
https://github.com/apache/incubator-kie-drools/pull/6389#discussion_r2179680385
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/RangeFunction.java:
##########
@@ -181,6 +186,18 @@ protected boolean nodesReturnsSameType(Object leftObject,
Object rightObject) {
}
}
+ /**
+ * @param leftObject
+ * @param rightObject
+ * @return It checks if the leftObject is lower or equals to rightObject,
false otherwise. If one of the endpoints is null,
+ * the endpoint range is considered to be in ascending order.
+ */
+ @SuppressWarnings("unchecked")
+ protected boolean nodesValueRangeAreAscending(Object leftObject, Object
rightObject) {
Review Comment:
@yesamer The null check in place doesn't cover that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
