yesamer commented on code in PR #6389:
URL:
https://github.com/apache/incubator-kie-drools/pull/6389#discussion_r2179875425
##########
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/functions/RangeFunctionTest.java:
##########
@@ -356,6 +356,26 @@ void nodesEndpointsAscendant_True() {
assertThat(rangeFunction.nodesValueRangeAreAscending(left, right))
.withFailMessage("P2DT20H14M - P2DT20H15M")
.isTrue();
+ left = new NullNode("null");
Review Comment:
@gitgabrio It's the opposite, if there is at least one null endpoint, that
method returns true. That method's scope is to return false when the two
endpoints defines a descendant range, and with at least one null node that is
NOT the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
