gitgabrio opened a new pull request, #4229: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4229
Fixes https://github.com/apache/incubator-kie-issues/issues/2253 The original issue was mainly that, with lot (~3500) dmn models to manage, the generated DecisionModels class become too big to be read. That also raised the doubt about having so many streams opened at once. The proposed solution is: 1. create a "modelPaths.txt" file that contains the path of each model and its charset (e.g. ``` /valid_models/DMNv1_5/Importing_EmptyNamed_Model_With_Href_Namespace.dmn:UTF-8 /valid_models/DMNv1_5/Imported_Model_Unamed.dmn:UTF-8 /valid_models/DMNv1_5/TypeConstraintsChecks.dmn:UTF-8 /valid_models/DMNv1_5/AllowedValuesChecksInsideCollection.dmn:UTF-8 ``` inside DecisionCodeGenUtils.generateModelPathsFile() 2. create new methods to allow this different codepath without breaking backward compatibility 3. parse that file to a Map only soon after the dmn runtime gets instantiated (inside AbstractDecisionModels.init) 4. instantiate the dmnRuntime with the map provided above Caveat: while this could resolve the initial issue, it is to be verified how the rest of the execution would behave with so many models to manage. <details> <summary> How to replicate CI configuration locally? </summary> Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
