yesamer commented on code in PR #4229:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4229#discussion_r3116784634
##########
kogito-codegen-modules/kogito-codegen-decisions/src/main/java/org/kie/kogito/codegen/decision/DecisionCodegenUtils.java:
##########
@@ -334,6 +360,25 @@ static void
generateAndStoreDecisionModelResourcesProvider(Collection<GeneratedF
storeFile(generatedFiles, GeneratedFileType.SOURCE,
generator.generatedFilePath(), generator.generate());
}
+ private static Optional<String> determineEncoding(CollectedResource
resource) {
+ try {
+ BufferedReader br = new
BufferedReader(resource.resource().getReader());
+ StringBuilder sb = new StringBuilder(br.readLine());
+ sb.append(br.readLine());
+ String head = sb.toString();
+ boolean prologUTF8 = head.startsWith("<?xml version=\"1.0\"
encoding=\"UTF-8\"") || head.startsWith("<?xml version=\"1.0\"
encoding=\"utf-8\"");
+ boolean kogitoDMNEditor =
head.contains("xmlns:kie=\"http://www.drools.org/kie/dmn";);
Review Comment:
AH ok, I noticed that code was already there, you just moved it.
##########
kogito-codegen-modules/kogito-codegen-decisions/src/main/java/org/kie/kogito/codegen/decision/DecisionCodegenUtils.java:
##########
@@ -334,6 +360,25 @@ static void
generateAndStoreDecisionModelResourcesProvider(Collection<GeneratedF
storeFile(generatedFiles, GeneratedFileType.SOURCE,
generator.generatedFilePath(), generator.generate());
}
+ private static Optional<String> determineEncoding(CollectedResource
resource) {
+ try {
+ BufferedReader br = new
BufferedReader(resource.resource().getReader());
+ StringBuilder sb = new StringBuilder(br.readLine());
+ sb.append(br.readLine());
+ String head = sb.toString();
+ boolean prologUTF8 = head.startsWith("<?xml version=\"1.0\"
encoding=\"UTF-8\"") || head.startsWith("<?xml version=\"1.0\"
encoding=\"utf-8\"");
+ boolean kogitoDMNEditor =
head.contains("xmlns:kie=\"http://www.drools.org/kie/dmn";);
Review Comment:
@gitgabrio Just out of curiosity, why is this logic required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
