thiagoelg commented on code in PR #3538: URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3079828477
########## packages/maven-quarkus-bom/pom.xml: ########## @@ -0,0 +1,66 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> +<project + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"; + xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +> + <parent> + <groupId>org.kie</groupId> + <artifactId>kie-tools-maven-base</artifactId> + <version>${revision}</version> + <relativePath>../maven-base/pom.xml</relativePath> + </parent> + + <modelVersion>4.0.0</modelVersion> + <artifactId>kie-tools-quarkus-bom</artifactId> + <packaging>pom</packaging> + + <name>KIE Tools :: Quarkus BOM</name> + <description>Bill of Materials for KIE Tools Quarkus-based projects</description> + + <properties> + <version.io.quarkus>3.27.2</version.io.quarkus> Review Comment: kie-tools should follow the same Quarkus version from the upstream repositories. The `QUARKUS_PLATFORM_version` env var is used in other places as well, not just POMs (some container images and Sonataflow packages), so we can't just straight remove it. Ideally, the default value of `QUARKUS_PLATFORM_version` should come from the `kogito-apps-bom` built by the `drools-and-kogito` package automatically; this way, it's always in sync. I'm not sure how to programmatically retrieve a property from a POM, but if it's possible, that would be nice. Otherwise, we can maintain the `QUARKUS_PLATFORM_version` value manually for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
