tiagobento commented on code in PR #3538:
URL:
https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3080659836
##########
packages/jbpm-quarkus-devui/jbpm-quarkus-devui-runtime/pom.xml:
##########
@@ -141,7 +141,6 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-extension-maven-plugin</artifactId>
- <version>${version.quarkus}</version>
Review Comment:
This will make it default to the latest version, if I'm not mistaken
##########
packages/maven-quarkus-bom/package.json:
##########
@@ -0,0 +1,39 @@
+{
+ "private": true,
+ "name": "@kie-tools/maven-quarkus-bom",
Review Comment:
Let's follow whatever `maven-base` used to do.
##########
packages/maven-base/pom.xml:
##########
@@ -122,94 +122,25 @@
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<!-- Apache KIE -->
- <version.org.kie.kogito>999-20260324-local</version.org.kie.kogito>
-
- <!-- Quarkus -->
- <version.quarkus>3.27.2</version.quarkus>
+ <version.org.kie.kogito>999-20260414-local</version.org.kie.kogito>
<!-- 3rd party dependencies -->
- <version.junit>4.13.2</version.junit>
-
<version.org.apache.commons.commons-compress>1.28.0</version.org.apache.commons.commons-compress>
<version.org.iq80.snappy>0.5</version.org.iq80.snappy>
<version.org.apache.mime4j>0.8.12</version.org.apache.mime4j>
- <version.org.freemarker>2.3.34</version.org.freemarker>
- <version.org.assertj>3.27.7</version.org.assertj>
- <version.org.junit.jupiter>5.13.4</version.org.junit.jupiter>
- <version.org.mockito>5.18.0</version.org.mockito>
<version.org.kie.j2cl.tools.yaml.mapper>0.4</version.org.kie.j2cl.tools.yaml.mapper>
- <version.io.netty>4.1.131.Final</version.io.netty>
-
- <!-- These versions are overrides for transitive dependencies, to fix
security vulnerabilities.
- They need to be checked with Quarkus and Spring Boot upgrades and
eventually removed, if they are not needed anymore. -->
- <version.tomcat.embed.core>10.1.54</version.tomcat.embed.core>
- <version.apache.commons.lang3>3.18.0</version.apache.commons.lang3>
- <version.angus.mail>2.0.5</version.angus.mail>
Review Comment:
Why do we need to remove all those dependencies from here? Are they tightly
coupled with Quarkus or Spring Boot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
