yesamer commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3137576321
##########
bom/drools-bom/pom.xml:
##########
@@ -1045,11 +1045,12 @@
<artifactId>default-kiesession</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
+ <!-- NOT SURE ABOUT THIS ONE!!!! -->
+ <!--<dependency>
<groupId>org.drools</groupId>
<artifactId>cdi-example</artifactId>
<version>${project.version}</version>
- </dependency>
+ </dependency>-->
Review Comment:
@gitgabrio Are you now sure? :)
##########
pom.xml:
##########
@@ -133,8 +133,13 @@
</build>
<modules>
+ <module>kie-no-dependencymanagement-enforcer-rule</module>
+ <module>kie-no-external-manageddependency-enforcer-rule</module>
Review Comment:
As names, what about
```
kie-no-dependency-management-enforcer-rule
kie-no-external-managed-dependency-enforcer-rule
```
?
##########
bom/drools-bom/pom.xml:
##########
@@ -1095,18 +1096,6 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
-
- <dependency>
- <groupId>org.drools</groupId>
- <artifactId>drools-scorecards</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.drools</groupId>
- <artifactId>drools-scorecards</artifactId>
- <version>${project.version}</version>
- <classifier>sources</classifier>
- </dependency>
Review Comment:
@gitgabrio Was this removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
