nrknithin commented on code in PR #4270: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4270#discussion_r3233687242
########## springboot/addons/jobs/src/main/java/org/kie/kogito/jobs/management/springboot/AddonObjectMapperBuilderCustomizer.java: ########## @@ -19,15 +19,26 @@ package org.kie.kogito.jobs.management.springboot; import org.kie.kogito.jobs.service.api.serialization.SerializationUtils; -import org.springframework.boot.autoconfigure.jackson.Jackson2ObjectMapperBuilderCustomizer; +import org.springframework.beans.factory.config.BeanPostProcessor; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; +import com.fasterxml.jackson.databind.ObjectMapper; + +// TODO Jackson 3 migration: switch to tools.jackson.databind.ObjectMapper and remove this BeanPostProcessor. Review Comment: Linked the tracking issue here and on the matching sites across kogito-runtimes, kogito-apps, and kogito-examples. The issue ([drools #6702](https://github.com/apache/incubator-kie-drools/issues/6702)) body lists every Jackson-2-helper location for a single-shot removal. ########## springboot/addons/jobs/src/test/java/org/kie/kogito/jobs/management/springboot/AddonObjectMapperBuilderCustomizerTest.java: ########## @@ -19,14 +19,16 @@ package org.kie.kogito.jobs.management.springboot; import org.junit.jupiter.api.Test; -import org.springframework.boot.autoconfigure.jackson.Jackson2ObjectMapperBuilderCustomizer; +import org.springframework.beans.factory.config.BeanPostProcessor; import static org.assertj.core.api.Assertions.assertThat; +// TODO Jackson 3 migration: switch to tools.jackson.databind.ObjectMapper (Jackson 3) once the +// post-BOM-split Spring-side migration moves AddonObjectMapperBuilderCustomizer to Jackson 3. Review Comment: Linked the tracking issue here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
