nrknithin commented on code in PR #4270:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4270#discussion_r3239144482
##########
kogito-gradle-plugin/src/main/java/org/kie/kogito/gradle/plugin/KogitoGradleExtension.java:
##########
@@ -39,11 +39,18 @@ public KogitoGradleExtension(Project gradleProject) {
projectBaseDir = gradleProject.getObjects().property(File.class);
projectBaseDir.set(gradleProject.getLayout().getProjectDirectory().getAsFile());
+ // kogito-codegen treats projectBuildOutputDirectory as the classpath
directory where it
+ // writes generated resources (dmnModelPaths.txt,
processModelPaths.txt, ...). Use Gradle's
+ // main-classes directory so those resources land on the runtime
classpath, matching the
+ // Maven equivalent of ${project.build.outputDirectory} =
target/classes.
Review Comment:
@yesamer this change is not actually needed — I will revert it. The local
Gradle tests were failing during the upgrade with No URL provided for
`dmnModelPaths.txt;` I changed `projectBuildOutputDirectory` to line up with
how the Maven side writes files, the failures stopped, and I kept the change
thinking it was the fix. On re-checking, the local failure was a Gradle daemon
cold-start issue (warm daemon passes; CI runs modules sequentially so it stays
warm) — not something this code change affects. Removing it from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
