Copilot commented on code in PR #4241:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3240087658
##########
addons/common/persistence/mongodb/pom.xml:
##########
@@ -50,7 +50,6 @@
<dependency>
<groupId>org.mongodb</groupId>
<artifactId>mongodb-driver-sync</artifactId>
- <version>${version.org.mongo}</version><!-- Do not use managed version
as SB and Quarkus use different versions -->
<scope>provided</scope>
Review Comment:
This dependency is now missing a version: the PR removes the local
dependencyManagement entry and no remaining POM in this repository manages
org.mongodb:mongodb-driver-sync. Maven will fail while building this module
unless the version is restored or added to an inherited BOM.
##########
springboot/integration-tests/integration-tests-springboot-processes-persistence-it/integration-tests-springboot-processes-infinispan/pom.xml:
##########
@@ -32,18 +32,6 @@
<artifactId>integration-tests-springboot-processes-infinispan</artifactId>
<name>Kogito :: Integration Tests :: Spring Boot :: Processes :: Persistence
:: Infinispan</name>
- <dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.infinispan</groupId>
- <artifactId>infinispan-bom</artifactId>
- <version>${version.org.infinispan}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
- </dependencies>
- </dependencyManagement>
-
<dependencies>
<dependency>
<groupId>org.jbpm</groupId>
Review Comment:
Removing the Infinispan BOM leaves this module's
org.infinispan:infinispan-spring-boot3-starter-remote dependency unmanaged; no
remaining dependencyManagement entry for that artifact exists in the
repository. Maven requires a version for that dependency, so this module will
fail to build.
##########
.github/workflows/pr-kogito-runtimes.yml:
##########
@@ -65,7 +65,9 @@ jobs:
with:
annotations-prefix: ${{ runner.os }}-${{ matrix.java-version }}/${{
matrix.maven-version }}
github-token: "${{ secrets.GITHUB_TOKEN }}"
- definition-file:
https://raw.githubusercontent.com/${GROUP:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/pull-request-config.yaml
+ # TODO REMOVE THIS TEMPORARY OVERRIDE ONCE THE PULL REQUEST CONFIG
FILE IS UPDATED IN THE MAIN BRANCH
+ # definition-file:
https://raw.githubusercontent.com/${GROUP:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/pull-request-config.yaml
+ definition-file:
https://raw.githubusercontent.com/gitgabrio/incubator-kie-kogito-pipelines/remove_unwanted_reproducible/.ci/pull-request-config.yaml
Review Comment:
This workflow now runs CI from a personal fork/branch instead of the Apache
pipeline configuration. That makes PR validation depend on mutable external
content outside the project and should not be merged as-is.
##########
kogito-codegen-modules/kogito-codegen-api/pom.xml:
##########
@@ -33,26 +33,7 @@
<properties>
<java.module.name>org.kie.kogito.codegen.api</java.module.name>
- <version.org.yaml.snakeyaml>2.6</version.org.yaml.snakeyaml>
</properties>
Review Comment:
snakeyaml is still declared in this module without a version, but the PR
removes both the local version property and the dependencyManagement entry for
org.yaml:snakeyaml, and no remaining repository BOM manages it. This will make
the module fail Maven model validation.
##########
addons/common/events/mongodb/pom.xml:
##########
@@ -54,7 +54,6 @@
<dependency>
<groupId>org.mongodb</groupId>
<artifactId>mongodb-driver-sync</artifactId>
Review Comment:
This dependency is left without a managed version after the local version
was removed. A repository-wide search only finds mongodb-driver-sync here and
in the Spring Boot BOM property, but no dependencyManagement entry for it, so
Maven will reject this POM.
##########
kogito-build/kogito-build-no-bom-parent/pom.xml:
##########
@@ -683,7 +683,7 @@
<goals>
<goal>highest-basedir</goal>
</goals>
- <phase>validate</phase>
+ <phase>none</phase>
<configuration>
<property>project.root.dir</property>
Review Comment:
The build-helper execution that sets project.root.dir has been effectively
disabled by binding it to phase "none", but project.root.dir is still used for
JaCoCo output and the DDL assembly paths. Those paths will now expand with an
unresolved property during normal builds.
##########
kogito-gradle-plugin/pom.xml:
##########
@@ -40,68 +40,10 @@
<name>Kogito :: Gradle :: Plugin</name>
<description>Plugin to build applications using Gradle</description>
- <!-- DO NOT ADD PARENT DECLARATION TO HAVE THAT PLUGIN DISCOVERABLE BY
GRADLE -->
<properties>
- <maven.compiler.source>17</maven.compiler.source>
- <maven.compiler.target>17</maven.compiler.target>
- <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.module.name>org.kie.kogito.gradle.plugin</java.module.name>
- <gradle.version>8.11.1</gradle.version>
- <groovy.version>4.0.29</groovy.version>
</properties>
Review Comment:
The Gradle plugin dependencies dev.gradleplugins:gradle-api,
dev.gradleplugins:gradle-test-kit, and the org.apache.groovy artifacts still
appear later in this POM without versions, but the PR removes the only local
version properties/dependencyManagement for them and no repository BOM manages
them. This POM will fail Maven model validation.
##########
.github/workflows/pr-downstream.yml:
##########
@@ -81,8 +81,10 @@ jobs:
annotations-prefix: ${{ runner.os }}-${{ matrix.java-version }}/${{
matrix.maven-version }}
starting-project: apache/${{ matrix.repository }}
github-token: "${{ secrets.GITHUB_TOKEN }}"
- definition-file:
https://raw.githubusercontent.com/${GROUP:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/pull-request-config.yaml
- env:
+ # TODO REMOVE THIS TEMPORARY OVERRIDE ONCE THE PULL REQUEST CONFIG
FILE IS UPDATED IN THE MAIN BRANCH
+ # definition-file:
https://raw.githubusercontent.com/${GROUP:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/pull-request-config.yaml
+ definition-file:
https://raw.githubusercontent.com/gitgabrio/incubator-kie-kogito-pipelines/remove_unwanted_reproducible/.ci/pull-request-config.yaml
Review Comment:
This workflow now runs downstream CI from a personal fork/branch instead of
the Apache pipeline configuration. That makes validation depend on mutable
external content outside the project and should not be merged as-is.
##########
quarkus/pom.xml:
##########
@@ -44,18 +44,4 @@
<module>test</module>
<module>integration-tests</module>
</modules>
Review Comment:
The quarkus.http.test-port=0 failsafe property was removed and no
replacement remains under the quarkus tree. Quarkus tests will fall back to the
default fixed test port, which can cause parallel module builds to collide on
the same port.
##########
quarkus/extensions/kogito-quarkus-processes-extension/kogito-quarkus-processes-integration-test-hot-reload/pom.xml:
##########
@@ -110,7 +97,6 @@
<dependency>
<groupId>com.github.stephenc.jcip</groupId>
<artifactId>jcip-annotations</artifactId>
- <version>${version.com.github.stephenc.jcip}</version>
<scope>test</scope>
Review Comment:
jcip-annotations is now versionless after removing the explicit version, and
no remaining repository BOM manages com.github.stephenc.jcip:jcip-annotations.
This module will fail Maven dependency validation.
##########
quarkus/addons/messaging/common/pom.xml:
##########
@@ -109,7 +109,6 @@
<dependency>
<groupId>com.github.stephenc.jcip</groupId>
<artifactId>jcip-annotations</artifactId>
- <version>${version.com.github.stephenc.jcip}</version>
<scope>test</scope>
Review Comment:
jcip-annotations is left without a version here, but the removed version
property is not managed anywhere else in the repository. This dependency needs
an explicit or inherited version for Maven to build the module.
##########
quarkus/extensions/kogito-quarkus-extension/kogito-quarkus-integration-test-maven-devmode/pom.xml:
##########
@@ -98,13 +85,11 @@
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-test-maven</artifactId>
- <version>${version.io.quarkus.quarkus-test}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.github.stephenc.jcip</groupId>
<artifactId>jcip-annotations</artifactId>
- <version>${version.com.github.stephenc.jcip}</version>
<scope>test</scope>
Review Comment:
jcip-annotations is still declared later in this POM without a version, but
the PR removes the explicit version and no remaining repository BOM manages
com.github.stephenc.jcip:jcip-annotations. Maven will fail to build this module
unless the version is restored or managed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
