gitgabrio commented on code in PR #4241:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086247215
##########
kogito-build/kogito-build-no-bom-parent/pom.xml:
##########
@@ -683,7 +665,7 @@
<goals>
<goal>highest-basedir</goal>
</goals>
- <phase>validate</phase>
+ <phase>none</phase>
Review Comment:
During the modifications, I discovered that this plugin break the build
because it fails to find one single "project.root.dir" when the parent of a
module is not the super-module, i.e.
supermodule \
module-a
module-b
if the parent of any of module-a or mudle-b is not supermodule, the plugin
throws an exception because it identify two potential "parents": is that clear ?
Anyway, I'll double-check ASAP to verify again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
