drccrd commented on code in PR #3665: URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608690177
########## packages/drools-lsp/pom.xml: ########## @@ -0,0 +1,81 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> +<project + xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"; +> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.kie</groupId> + <artifactId>kie-tools-maven-base</artifactId> + <version>${revision}</version> + <relativePath>./node_modules/@kie-tools/maven-base/pom.xml</relativePath> + </parent> + + <groupId>org.kie.tools</groupId> + <artifactId>drools-lsp</artifactId> + <packaging>pom</packaging> + + <properties> + <version.org.antlr4>4.10.1</version.org.antlr4> + <version.org.eclipse.lsp4j>0.19.0</version.org.eclipse.lsp4j> + <version.antlr4-c3>1.1</version.antlr4-c3> + <version.org.junit>5.9.1</version.org.junit> + <version.junit.platform>1.9.1</version.junit.platform> + <version.org.assertj>3.23.1</version.org.assertj> + <version.ch.qos.logback>1.5.16</version.ch.qos.logback> Review Comment: @tkobayas it appears that the ANTLR version may now be unpinned. From Claude: ANTLR toolchain version change (the item most worth confirming) — module POMs dropped their pinned versions; maven-base/pom.xml.template now sets the antlr4-maven-plugin to 4.13.2 (was 4.10.1 in the source), while antlr4-runtime/antlr4 are left unmanaged in maven-base and resolve transitively through the imported kogito-apps-bom. The source project pinned the entire ANTLR stack to 4.10.1. Since drools-parser underlies all completion/lint/hover behavior, and ANTLR wants the generator tool and runtime aligned, this is a real (if low-probability) behavior risk: the parser is now generated by a newer tool against a BOM-dictated runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
