drccrd commented on code in PR #3665: URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608693425
########## packages/drl-vscode-extension/README.md: ########## @@ -0,0 +1,29 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +## DRL Editor + +Edit DRL (Drools Rule Language) files with language support provided by the [DRL Language Server](../drools-lsp). + +## Features + +- Syntax highlighting for `.drl` files. +- LSP features backed by a local JVM running the DRL Language Server: completion, diagnostics, hover, go-to-definition, references, document symbols, code lenses, folding ranges, inlay hints, and rename. + +## Requirements Review Comment: other requirements (e.g. maven) are no longer listed - add them, or refer to a parent-repo readme? ########## packages/drl-vscode-extension/package.json: ########## @@ -0,0 +1,196 @@ +{ + "name": "drl-vscode-extension", + "version": "0.0.0", + "description": "Edit DRL (Drools Rule Language) files", + "license": "Apache-2.0", + "publisher": "kie-group", + "keywords": [], + "homepage": "https://github.com/apache/incubator-kie-tools";, + "repository": { + "type": "git", + "url": "https://github.com/apache/incubator-kie-tools.git"; + }, + "bugs": { + "url": "https://github.com/apache/incubator-kie-tools/issues"; + }, + "main": "dist/extension/extension.js", + "scripts": { + "build:dev": "rimraf dist && webpack --env dev", + "build:prod": "rimraf dist && webpack && pnpm pack:prod", + "compile": "webpack", + "lint": "run-script-if --bool \"$(build-env linters.run)\" --then \"kie-tools--eslint ./src\"", + "pack:prod": "vsce package --githubBranch main --no-dependencies -o ./dist/drl_vscode_extension_$npm_package_version.vsix", + "pretest": "pnpm build:dev && mvn -f src/testFixture/pom.xml -ntp compile && tsc -p tsconfig.test.json", + "test": "node ./out-test/test/runTest.js", + "watch": "export WEBPACK__sourceMaps=true; WEBPACK__minimize=false; webpack --env dev" + }, + "dependencies": { + "vscode-languageclient": "^9.0.1" + }, + "devDependencies": { + "@kie-tools-core/webpack-base": "workspace:*", + "@kie-tools-scripts/build-env": "workspace:*", + "@kie-tools/drools-lsp": "workspace:*", + "@kie-tools/eslint": "workspace:*", + "@kie-tools/root-env": "workspace:*", + "@kie-tools/tsconfig": "workspace:*", + "@types/mocha": "^10.0.7", + "@types/vscode": "1.67.0", Review Comment: engines.vscode is `^1.103.0` below - if the minimum is 103 the API could be as well? I haven't checked compatibility yet but wouldn't expect any breaking changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
