pefernan commented on code in PR #4346: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4346#discussion_r3621811003
########## jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DynamicSubProcessTest.java: ########## @@ -0,0 +1,610 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.jbpm.bpmn2; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.jbpm.process.instance.impl.ProcessInstanceImpl; +import org.jbpm.workflow.instance.impl.WorkflowProcessInstanceImpl; +import org.junit.jupiter.api.Test; +import org.kie.api.event.process.ProcessCompletedEvent; +import org.kie.api.event.process.ProcessStartedEvent; +import org.kie.kogito.internal.process.runtime.KogitoProcessInstance; +import org.kie.kogito.internal.process.runtime.KogitoWorkflowProcessInstance; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for the dynamic subprocess feature introduced on the Review Comment: Although comments are always welcome, please try to make them more concise :) ########## jbpm/jbpm-flow/src/test/java/org/jbpm/process/test/NodeCreator.java: ########## @@ -37,7 +37,11 @@ public class NodeCreator<T extends NodeImpl> { public NodeCreator(NodeContainer nodeContainer, Class<T> clazz) { this.nodeContainer = nodeContainer; - this.constructor = (Constructor<T>) clazz.getConstructors()[0]; + try { Review Comment: is this change required? ########## jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/SubProcessNodeInstance.java: ########## @@ -95,6 +95,15 @@ public void internalTrigger(final KogitoNodeInstance from, String type) { } String processId = resolveExpression(processIdExpression); + if (isExpression(processIdExpression)) { Review Comment: Do we need this check this? Considering that the main change is to support dynamic nodeinstance in LambdaSubProcessNodeInstance I thought no change on this class would be required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
