martinweiler commented on code in PR #4346:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4346#discussion_r3624882059
##########
jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/LambdaSubProcessNodeInstance.java:
##########
@@ -294,4 +305,35 @@ public ContextContainer getContextContainer() {
return getSubProcessNode();
}
+ /**
+ * Resolves the process ID from the {@code calledElement} attribute.
+ * Supports static IDs and MVEL expressions (e.g. {@code #{subprocessId}}).
+ * Throws {@link IllegalArgumentException} with a descriptive message when
+ * the expression resolves to a blank or unresolved value.
+ */
+ private String resolveProcessId() {
+ String processId = getSubProcessNode().getProcessId();
+
+ if (processId == null) {
+ return null;
+ }
+
+ String resolvedId = resolveExpression(processId);
Review Comment:
Looking at the 7.67.x code in
[SubProcessNodeInstance](https://github.com/kiegroup/jbpm/blob/7.67.x-blue/jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/SubProcessNodeInstance.java#L141-L168)
I think we supported multiple expressions in one variable, eg. something like
`subprocess-#{varA}-#{typeA}`. @Christine-Jose can you please verify this and
adjust the logic here, if needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
