yesamer commented on code in PR #6903:
URL: https://github.com/apache/incubator-kie/pull/6903#discussion_r3881814006
##########
optaplanner-build/optaplanner-build-parent/pom.xml:
##########
Review Comment:
@nrknithin I guess this is now unused, as you removed the declaration.
##########
kogito-quarkus/addons/knative/eventing/integration-tests/src/test/java/org/kie/kogito/addons/quarkus/knative/eventing/KSinkInjectionHealthCheckEnabledIT.java:
##########
@@ -39,7 +37,6 @@ class KSinkInjectionHealthCheckEnabledIT extends
AbstractKSinkInjectionHealthChe
@Test
void kSinkInjectionHealthEnabled() {
- assertThat(config.getOptionalValue(CONFIG_ALIAS,
Boolean.class)).hasValue(true);
Review Comment:
@nrknithin Why no longer needed?
##########
kogito-quarkus/addons/knative/eventing/integration-tests/src/test/java/org/kie/kogito/addons/quarkus/knative/eventing/KSinkInjectionHealthCheckDisabledIT.java:
##########
@@ -40,7 +38,6 @@ class KSinkInjectionHealthCheckDisabledIT extends
AbstractKSinkInjectionHealthCh
@Test
void kSinkInjectionHealthDisabled() {
- assertThat(config.getOptionalValue(CONFIG_ALIAS,
Boolean.class)).hasValue(false);
Review Comment:
@nrknithin Why no longer needed?
##########
kogito-apps-quarkus/jobs-service-quarkus/jobs-service-infinispan/pom.xml:
##########
@@ -66,10 +66,6 @@
<artifactId>quarkus-infinispan-client</artifactId>
</dependency>
<!-- Needs to be declared as Jobs service doesn't leverage
persistence-commons-infinispan. -->
- <dependency>
- <groupId>org.infinispan</groupId>
- <artifactId>infinispan-query-dsl</artifactId>
- </dependency>
Review Comment:
@nrknithin Why no longer needed? In such a case, please remove the above
comment
##########
kogito-quarkus/addons/knative/eventing/integration-tests/src/test/java/org/kie/kogito/addons/quarkus/knative/eventing/AbstractKSinkInjectionHealthCheckIT.java:
##########
@@ -18,22 +18,12 @@
*/
package org.kie.kogito.addons.quarkus.knative.eventing;
-import org.eclipse.microprofile.config.Config;
-import org.eclipse.microprofile.config.ConfigProvider;
import org.hamcrest.Matcher;
-import org.junit.jupiter.api.BeforeEach;
import static io.restassured.RestAssured.given;
abstract class AbstractKSinkInjectionHealthCheckIT {
- Config config;
-
- @BeforeEach
- void setUp() {
- config = ConfigProvider.getConfig();
Review Comment:
@nrknithin Why no longer needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
