nrknithin commented on code in PR #6903:
URL: https://github.com/apache/incubator-kie/pull/6903#discussion_r3926425799
##########
kie-parent/pom.xml:
##########
@@ -148,13 +148,13 @@
<version.io.netty>4.1.136.Final</version.io.netty>
<version.io.opentelemetry>1.0.0-alpha</version.io.opentelemetry>
<version.io.rest-assured>5.5.6</version.io.rest-assured>
- <version.io.smallrye-config>3.13.4</version.io.smallrye-config>
- <version.io.smallrye-health>4.2.0</version.io.smallrye-health>
- <version.io.smallrye-open-api>4.0.12</version.io.smallrye-open-api>
- <version.io.smallrye.config.core>3.13.4</version.io.smallrye.config.core>
- <version.io.smallrye.jandex>3.4.0</version.io.smallrye.jandex>
+ <version.io.smallrye-config>3.16.0</version.io.smallrye-config>
+ <version.io.smallrye-health>4.3.0</version.io.smallrye-health>
+ <version.io.smallrye-open-api>4.2.4</version.io.smallrye-open-api>
+ <version.io.smallrye.config.core>3.16.0</version.io.smallrye.config.core>
+ <version.io.smallrye.jandex>3.5.3</version.io.smallrye.jandex>
<version.io.smallrye.mutiny>2.9.5</version.io.smallrye.mutiny>
- <version.io.smallrye.openapi.core>4.0.12</version.io.smallrye.openapi.core>
+ <version.io.smallrye.openapi.core>4.2.4</version.io.smallrye.openapi.core>
Review Comment:
Good catch @pefernan — you're right, some of these don't belong in
kie-parent.
**Moved out:**
- smallrye-health → Quarkus BOM. Only one pom used it, kogito-quarkus/bom,
and kie-parent didn't manage any artifact with it.
- jcip-annotations, json-smart, graalvm svm, jredisearch, org.json → Quarkus
BOM. Only Quarkus modules declare them.
- reactive-streams, spock-core → Spring Boot BOM. Only Spring Boot modules
declare them.
- springdoc → removed. kogito-spring-boot-bom already had it, so
kie-parent's copy was a duplicate.
**Left in kie-parent, with reasons:**
- smallrye-config — kie-parent uses it for smallrye-config-core, and a
Spring Boot IT reads the property directly, so it would break if moved.
- smallrye-open-api — kie-parent uses it for smallrye-open-api-ui/-vertx,
and kogito-spring-boot-bom uses the same property. Both sides need it.
- hamcrest-all — not all of its consumers inherit from the Quarkus BOM.
- io.fabric8 — kie-parent imports the kubernetes-client BOM with it, and the
Spring Boot BOM already overrides it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
