nrknithin commented on code in PR #6903:
URL: https://github.com/apache/incubator-kie/pull/6903#discussion_r3948872455
##########
kogito-quarkus/bom/pom.xml:
##########
@@ -31,17 +31,71 @@
<!-- Used to define which poms are allowed to have dependencyManagement
sections. This is to enforce the convention that only the root pom should have
dependencyManagement, and all other poms should inherit from it. -->
<allowedPomsList>org.kie.kogito:kogito-quarkus-bom</allowedPomsList>
<quarkus.logging.manager>org.jboss.logmanager.LogManager</quarkus.logging.manager>
- <version.io.quarkus>3.27.5.1</version.io.quarkus>
+ <version.io.quarkus>3.33.3.2</version.io.quarkus>
<version.io.quarkus.quarkus-test>${version.io.quarkus}</version.io.quarkus.quarkus-test>
<version.io.quarkiverse.jackson-jq>2.4.0</version.io.quarkiverse.jackson-jq>
-
<version.io.quarkiverse.openapi.generator>2.16.0-lts</version.io.quarkiverse.openapi.generator>
+
<version.io.quarkiverse.openapi.generator>2.17.0-lts</version.io.quarkiverse.openapi.generator>
<version.io.quarkiverse.asyncapi>1.0.5</version.io.quarkiverse.asyncapi>
-
<version.io.quarkiverse.reactivemessaging.http>2.5.0-lts</version.io.quarkiverse.reactivemessaging.http>
+
<version.io.quarkiverse.reactivemessaging.http>2.7.1</version.io.quarkiverse.reactivemessaging.http>
<version.io.quarkiverse.embedded.postgresql>0.8.0</version.io.quarkiverse.embedded.postgresql>
- <version.io.quarkus.camel>3.27.5.1</version.io.quarkus.camel>
- </properties>
+ <version.io.quarkus.camel>3.33.2</version.io.quarkus.camel>
+ <!-- Quarkus-platform-aligned pins. These live here, not in kie-parent, so
that the Quarkus upgrade does not
+ change what the Spring Boot side resolves. -->
+ <version.io.grpc>1.81.0</version.io.grpc>
+
<version.io.smallrye.reactive.messaging.in.memory>4.33.0</version.io.smallrye.reactive.messaging.in.memory>
+ <version.com.google.guava>33.5.0-jre</version.com.google.guava>
+ <version.io.smallrye.mutiny>3.1.1</version.io.smallrye.mutiny>
+ <version.org.hibernate>7.2.19.Final</version.org.hibernate>
+ <version.org.postgresql>42.7.13</version.org.postgresql>
+ <!-- Quarkus 3.33 hard requirements: smallrye-config 3.16
(quarkus-core/junit-config reference io.smallrye.config.Config)
+ and jandex 3.5 (arc-processor uses
MethodParameterInfo.nameOrDefault). The two smallrye-config properties are one
+ artifact family in kie-parent (they map to smallrye-config-core /
smallrye-config) and must move together. -->
+ <version.io.smallrye-config>3.16.0</version.io.smallrye-config>
+ <version.io.smallrye.config.core>3.16.0</version.io.smallrye.config.core>
+ <version.io.smallrye.jandex>3.5.3</version.io.smallrye.jandex>
+ <!-- quarkus-bom alignment; smallrye-open-api 4.2.4 requires jandex 3.5,
so it is pinned in the same scope as jandex. -->
+ <version.io.smallrye-open-api>4.2.4</version.io.smallrye-open-api>
+ <version.io.smallrye.openapi.core>4.2.4</version.io.smallrye.openapi.core>
+ <!-- quarkus-bom alignment; must match the bson/mongodb-driver-core
version quarkus-bom supplies. -->
+ <version.mongodb-driver-sync>5.6.4</version.mongodb-driver-sync>
+ <!-- quarkus-bom alignment only (Quarkus 3.33 works on 2.20.0). -->
+ <version.commons-io>2.21.0</version.commons-io>
Review Comment:
Agreed. There’s no Quarkus-specific reason for the override, and Quarkus
3.33 works fine with 2.20.0. Removed the override from both Quarkus BOMs, so it
remains managed globally by kie-parent.
##########
optaplanner-build/optaplanner-build-parent/pom.xml:
##########
@@ -262,6 +245,7 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-maven-plugin</artifactId>
<version>${version.io.quarkus}</version>
+ <extensions>true</extensions>
Review Comment:
Required since Quarkus 3.31 for quarkus-maven-plugin to work as a build
extension. Added it in both places where the plugin is declared.
##########
optaplanner-build/optaplanner-build-parent/pom.xml:
##########
Review Comment:
Still needed. Quarkus BOM 3.33.3.2 pins sshd at 2.17.1, which is below the
2.19.0 CVE fix. OptaPlanner doesn't inherit kie-parent, so its version can't
override this. Also corrected the comment to reference 2.17.1.
##########
drools-reliability/drools-reliability-tests/src/test/java/org/drools/reliability/test/ReliabilityTestBasics.java:
##########
@@ -142,8 +143,8 @@ static Stream<PersistedSessionOption.PersistenceStrategy>
strategyProviderFull()
public void setUp() {
if (((TestableStorageManager)
StorageManagerFactory.get().getStorageManager()).isRemote()) {
LOG.info("Starting InfinispanContainer");
- container = new InfinispanContainer()
- .withFileSystemBind("infinispan-remote-config",
"/user-config")
+ container = new
InfinispanContainer(InfinispanContainer.IMAGE_BASENAME + ":" +
Version.getMajorMinor());
Review Comment:
Not a misconfiguration. Infinispan 16 removed the no-arg constructor, and
the old constructor used the same IMAGE_BASENAME + ":" +
Version.getMajorMinor() value. This just keeps the previous default explicitly.
Would u suggest any other way to achieve the same results?
##########
drools-quarkus-extension/drools-quarkus-util-deployment/src/main/java/org/drools/quarkus/util/deployment/QuarkusAppPaths.java:
##########
@@ -52,7 +51,8 @@ private enum PathType {
}
protected QuarkusAppPaths(List<Path> projectPaths, Collection<Path>
classesPaths, boolean isJar) {
- super(projectPaths, classesPaths, isJar, AppPaths.BT,
JarResultBuildStep.MAIN, false);
+ // "main" = quarkus-app output subdir (formerly
JarResultBuildStep.MAIN, removed in Quarkus 3.33)
+ super(projectPaths, classesPaths, isJar, AppPaths.BT, "main", false);
Review Comment:
Agreed. AppPaths already defines MAIN_DIR = "main", so switched to
AppPaths.MAIN_DIR.
##########
drools-compiler/src/main/java/org/drools/compiler/builder/impl/processors/ReteCompiler.java:
##########
@@ -22,10 +22,10 @@
import java.util.Collection;
import org.drools.base.RuleBase;
-import org.drools.compiler.builder.impl.AssetFilter;
-import org.drools.compiler.compiler.PackageRegistry;
import org.drools.base.definitions.InternalKnowledgePackage;
import org.drools.base.definitions.rule.impl.RuleImpl;
+import org.drools.compiler.builder.impl.AssetFilter;
Review Comment:
These were fixing pre-existing CustomImportOrder issues and aren't related
to the upgrade. Reverted all three files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
