jhaabhijeet864 commented on PR #4083: URL: https://github.com/apache/incubator-kie-tools/pull/4083#issuecomment-6988112520
Thanks a lot for the detailed review @drccrd! Your suggestion to build the suppression index once in `validate()` using the lexer's comment tokens is spot on. It cleanly solves: 1. Suppressing `drools-deprecated` alongside `drools-lint` and `drools-type`. 2. Passing the suppression index directly into the individual lint passes so suppressed findings don't consume the `MAX_DIAGNOSTICS_PER_PASS` / cap. 3. Accurate line boundaries for multi-line block comments (`disable-next-line` anchoring after `*/`). 4. Eliminating string-copy overhead and custom comment parsing regexes. I will also: - Assign stable codes per family to `DeprecatedConstructs` (e.g. half-constraints, legacy operators, etc.). - Ensure `buildPropertyAccessActions` respects suppression so "convert all getter calls" does not rewrite suppressed accessors. - Handle typos in directive actions and codes with dedicated diagnostics. - Model region re-enablement as an exclusion set rather than expanding a hardcoded list. - Drop `#` comment handling to match DRL10. - Update the `README` with the directives and diagnostic codes. I'll push an update with these changes shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
